1.1.1 release candidate#302
Merged
jstone-lucasfilm merged 9 commits intoAcademySoftwareFoundation:dev_1.1.1from Apr 17, 2026
Merged
1.1.1 release candidate#302jstone-lucasfilm merged 9 commits intoAcademySoftwareFoundation:dev_1.1.1from
jstone-lucasfilm merged 9 commits intoAcademySoftwareFoundation:dev_1.1.1from
Conversation
Adding here the finalized logo. This is almost identical to the one posted on Slack, except: - extremely small adjustment to the arrow head, to make it perfectly centered on and orthogonal to the stroke - SVG was optimized to remove redundant elements (e.g. gradients). Main logo is now only 10Kb. PNGs exported at 800dpi.
…dation#218) Some minor changes are needed to improve the clarity of the wording (around the implementation of the coat details). I discovered these while using the spec myself to implement the Arnold version.
* Add a preliminary CHANGELOG.md. Updated the CHANGELOG to reflect recent enhancements and bug fixes, including changes to specular behavior and new parameters. Signed-off-by: Adrien Herubel <AdrienHerubel@users.noreply.github.com> --------- Signed-off-by: Adrien Herubel <AdrienHerubel@users.noreply.github.com> Co-authored-by: Adrien Herubel <AdrienHerubel@users.noreply.github.com>
* WIP * Updating various images, adding some new ones * Update index.html Signed-off-by: Adrien Herubel <AdrienHerubel@users.noreply.github.com> --------- Signed-off-by: Adrien Herubel <AdrienHerubel@users.noreply.github.com> Co-authored-by: Adrien Herubel <AdrienHerubel@users.noreply.github.com>
…eFoundation#262) * Remove unnecessary leading spaces * Add missing period * Provide high-level summary of Belcour-Barla approach and mention tradeoffs * Add a paragraph about an alternative "locally spectral" approach * Consolidate discussion of the surrounding media * Move diagram to avoid interrupting list of properties * Turn list of properties into a bulleted list * Remove unnecessary mention of Belcour-Barla paper in discussion of high-level physical properties * Avoid reductive description of effects of thickness and IOR properties * Streamline intro and use active tone * Remove unnecessary "Note that" * Add a comma * Final updates to wording for clarity and conciseness * Add a note about the thin film redistributing energy between reflection and transmission and not violating energy conservation * Clarify Belcour&Barla baseline for thin-film iridescence and allow first-principles alternative for spectral renderers --------- Co-authored-by: Adrien Herubel <AdrienHerubel@users.noreply.github.com>
virtualzavie
approved these changes
Apr 17, 2026
|
|
||
| <center>*Specification v1.1, 2024-06-28. <a href="https://github.com/AcademySoftwareFoundation/OpenPBR" title="Redirect to GitHub page"><img src="images/aswf-logo-black.svg" alt="homepage" height="18" style="vertical-align: middle; position: relative; bottom: 3px"/></a> *</center> | ||
| <style>bigger { font-style: italic; font-weight: normal; font-size: 115%;}</style> | ||
| <center><bigger><i>OpenPBR Surface specification v1.1.1, 2026-04-17.</i></bigger></center> |
Contributor
There was a problem hiding this comment.
Minor consideration: this is semantically not a title, whereas **OpenPBR Surface** was one.
| In the case of the metallic base the physics is somewhat ambiguous since, as described in the Metal section, the Fresnel factor for metal is defined according to the Schlick-based "F82-tint" parametrization which does not specify the underlying physical complex IOR. We suggest here that some reasonable approximation is employed to map the Fresnel factor to the best matching effective complex IOR, for example that described by [#Gulbrandsen2014]. | ||
| - The thin-film thickness is assumed to be smaller than the scale of the microfacets and the film is assumed to be smooth. With this assumption, in practice the effect is most easily incorporated directly into the Fresnel factor of the microfacet BSDFs of both the metal and dielectric-base layers (thus it is *not* represented by incorporating an explicit thin-film Slab into the model). | ||
|
|
||
| - In the case of a dielectric base, the thin film should also generate color fringes in the transmission lobe. This is important, for example, when rendering soap bubbles (see [#Belcour2017]). |
Contributor
There was a problem hiding this comment.
Shouldn't it be "thin-film"?
Contributor
|
Following on from the two inline suggestions, there is a pre-existing inconsistency in the BRDF formulas (not changed in this PR) that should be addressed to make the notation fully consistent. If we settle on Instead of fixing that up here in this back-port, let's just fix it properly in the 1.2 branch first. |
jstone-lucasfilm
merged commit de103ae
into
AcademySoftwareFoundation:dev_1.1.1
1 check passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR increases the version to 1.1.1 and backports any missing change in the branch, it also adds a complete changelog for 1.1 and 1.1.1.
Backported PRs :